Open
Conversation
Contributor
Author
|
DCA looks good. Four false positives removed -- no other changes. |
Contributor
There was a problem hiding this comment.
Pull request overview
Ports the Python UnreachableCode.ql query to use API graphs for recognizing contextlib.suppress usage, replacing the previous LegacyPointsTo-based resolution approach.
Changes:
- Replace
LegacyPointsToimport withsemmle.python.ApiGraphs. - Update
suppression_in_scopeto matchwith contextlib.suppress(...)using an API-graph-based call pattern.
Show a summary per file
| File | Description |
|---|---|
| python/ql/src/Statements/UnreachableCode.ql | Switches contextlib.suppress detection from points-to resolution to API graph matching. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Contributor
Author
|
DCA performance results seem to indicate a 10% slowdown for FreeCAD, but I've been unable to verify this locally. I think workflow failures is causing the reported data to be somewhat confused. (In my local testing, the query -- when run on FreeCAD -- takes only ~20s. Much faster than the original points-to based query.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple use of API graphs instead of points-to.